fix: cli tool logging #3749
Merged
fix: cli tool logging #3749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
reviewed
Jul 31, 2025
crates/goose-cli/src/session/mod.rs
Outdated
| } | ||
| }; | ||
| (formatted, Some(subagent_id.to_string()), Some(notification_type.to_string())) | ||
| (formatted, subagent_id.map(|s|s.to_string()), Some(notification_type.to_string())) |
Collaborator
There was a problem hiding this comment.
no changes to notificaation type?
Collaborator
Author
There was a problem hiding this comment.
yeah looking below, that should probably also not be coerced to Some
DOsinga
approved these changes
Jul 31, 2025
michaelneale
added a commit
that referenced
this pull request
Aug 1, 2025
* main: fix: cli tool logging (#3749)
michaelneale
added a commit
that referenced
this pull request
Aug 1, 2025
* main: fix: don't return full shell output when very large (#3750) fix: cli tool logging (#3749) Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559)
zanesq
added a commit
that referenced
this pull request
Aug 1, 2025
…ipe-chat-via-deeplink * 'main' of github.com:block/goose: Ensure more client (#3787) fix(ui): extension command text overflow (#3785) No tool role means we should not collapse messages (#3778) fix: bundle workflows (#3780) Update goose hints (#3758) integrate MCP UI (#2948) Fix claude model names (#3765) fix: don't return full shell output when very large (#3750) fix: cli tool logging (#3749)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a check here to write the output differently if it's a sub-agent, but with .unwrap_or(), we'd always hit that path