Skip to content

Conversation

@Developerayo
Copy link
Contributor

Fixes #1844

@zanesq zanesq requested review from baxen and michaelneale June 18, 2025 20:17
Copy link
Collaborator

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@DOsinga DOsinga self-assigned this Jul 16, 2025
@DOsinga
Copy link
Collaborator

DOsinga commented Jul 16, 2025

If this is still relevant, let's see if we can get it in soon! Can you do the DCO thing, resolve the conflicts (sorry!) and then also merge in master (I think that will resolve the error)

@Developerayo Developerayo force-pushed the bug/reqbody-limit-exc branch from 09f0011 to 778b034 Compare July 19, 2025 13:21
@Developerayo
Copy link
Contributor Author

If this is still relevant, let's see if we can get it in soon! Can you do the DCO thing, resolve the conflicts (sorry!) and then also merge in master (I think that will resolve the error)

resolved

@DOsinga
Copy link
Collaborator

DOsinga commented Jul 22, 2025

the checks are failing - can you have a look? probably just have to merge in master and push again

@ryleu
Copy link

ryleu commented Jul 28, 2025

push_message is just missing a closing bracket

@DOsinga
Copy link
Collaborator

DOsinga commented Jul 31, 2025

ugh, now we need cargo fmt

@DOsinga DOsinga merged commit 26cb850 into block:main Jul 31, 2025
7 of 8 checks passed
michaelneale added a commit that referenced this pull request Jul 31, 2025
* main:
  Increase req body limit (#2965)
  Stable goose info -v (#3760)
  Speed up app initialization and improve refresh crashing (#3717)
  docs: consolidate search session content, doc import recipe (#3759)
  Improve power save blocker mechanism (#3698)
  Ensure adding/removing extensions refreshes extensions list (#3695)
  Env parsing for primitive types (#3706)
  Autocompact + One Shot Summarization algorithm (#3559)
  fix: initial prompt not filled in after accepting new recipe (#3637)
  fix not being able to click on searchbar buttons in chat (#3723)
  center session summary modal description text (#3737)
  Persist first message to local history in case of failure or cancellation (#3744)
  Make the client more secure (#3742)
  feat: Allow configuring hints filename(s) (#3269)
  Add support for mouse back nav button to Settings screen (#3195)
  chore: Remove the wrong tailwind package (#3754)
  chore: fix typo in desktop readme for goosed (#3752)
  feat: upgrade rmcp (#3738)
  feat: allow users view and edit their non-secret config's (#3005)
  fix: View extensions link (#3751)
@michaelneale
Copy link
Collaborator

how did we merge this - has a failure?

pub struct Message {
pub id: Option<String>,
pub role: Role,
#[serde(default = "default_created")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break openapi?

michaelneale added a commit that referenced this pull request Aug 1, 2025
* main:
  fix: don't return full shell output when very large (#3750)
  fix: cli tool logging (#3749)
  Increase req body limit (#2965)
  Stable goose info -v (#3760)
  Speed up app initialization and improve refresh crashing (#3717)
  docs: consolidate search session content, doc import recipe (#3759)
  Improve power save blocker mechanism (#3698)
  Ensure adding/removing extensions refreshes extensions list (#3695)
  Env parsing for primitive types (#3706)
  Autocompact + One Shot Summarization algorithm (#3559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncation bug

4 participants