Skip to content

Conversation

@lifeizhou-ap
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap commented Aug 1, 2025

Why
Recipe does not load when opening with deep link

Root cause
It seems to be related to this PR #3717. In the PR, after the recipe deeplink is decoded, the parsed recipe is saved in the local storage

  • There are a few places that still get recipe via window.appConfig?.get?.('recipe')
  • The did-finish-load event happens after recipe decoding and was overwriting the decoded recipe.

Fix (short term)

  • Listen to recipe-decoded and update the recipe in the config

Currently recipe is in window.appConfig and localStorage. I feel we may think about using a single source of truth for recipe in the future.

@lifeizhou-ap lifeizhou-ap changed the base branch from main to release/1.2.0 August 1, 2025 06:52
zanesq added 2 commits August 1, 2025 11:21
…ipe-chat-via-deeplink

* 'main' of github.com:block/goose:
  Ensure more client (#3787)
  fix(ui): extension command text overflow (#3785)
  No tool role means we should not collapse messages (#3778)
  fix: bundle workflows (#3780)
  Update goose hints (#3758)
  integrate MCP UI (#2948)
  Fix claude model names (#3765)
  fix: don't return full shell output when very large (#3750)
  fix: cli tool logging (#3749)
@zanesq zanesq changed the base branch from release/1.2.0 to main August 1, 2025 18:30
Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM for now. I changed the base to main and will merge and cherry pick into the 1.2 release.

I think a great improvement that I want to get to soon would be to change the app to not load the welcome screen before loading a recipe from a deeplink so it goes directly to chat right away.

@zanesq zanesq merged commit ba9981d into main Aug 1, 2025
2 checks passed
@zanesq zanesq deleted the lifei/fix-open-recipe-chat-via-deeplink branch August 1, 2025 18:32
zanesq added a commit that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants