Skip to content

Increase req body limit #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 4 commits into from
Jul 31, 2025
Merged

Increase req body limit #2965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
778b034
fix: increase req body limit
Developerayo Jun 17, 2025
e0ac9ad
Merge branch 'main' into bug/reqbody-limit-exc
Developerayo Jul 29, 2025
7f458b4
misisng curly brace
Developerayo Jul 29, 2025
1e8b3a5
fmt
Developerayo Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/goose-server/src/routes/reply.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::utils::verify_secret_key;
use crate::state::AppState;
use axum::{
extract::State,
extract::{DefaultBodyLimit, State},
http::{self, HeaderMap, StatusCode},
response::IntoResponse,
routing::post,
Expand Down Expand Up @@ -387,9 +387,15 @@ async fn submit_tool_result(

pub fn routes(state: Arc<AppState>) -> Router {
Router::new()
.route("/reply", post(reply_handler))
.route(
"/reply",
post(reply_handler).layer(DefaultBodyLimit::max(50 * 1024 * 1024)),
)
.route("/confirm", post(confirm_permission))
.route("/tool_result", post(submit_tool_result))
.route(
"/tool_result",
post(submit_tool_result).layer(DefaultBodyLimit::max(10 * 1024 * 1024)),
)
.with_state(state)
}

Expand Down
5 changes: 5 additions & 0 deletions crates/goose/src/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,7 @@ impl From<PromptMessage> for Message {
pub struct Message {
pub id: Option<String>,
pub role: Role,
#[serde(default = "default_created")]
Copy link
Collaborator

@michaelneale michaelneale Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break openapi?

pub created: i64,
pub content: Vec<MessageContent>,
}
Expand Down Expand Up @@ -390,6 +391,10 @@ pub fn push_message(messages: &mut Vec<Message>, message: Message) {
}
}

fn default_created() -> i64 {
0 // old messages do not have timestamps.
}

impl Message {
pub fn new(role: Role, created: i64, content: Vec<MessageContent>) -> Self {
Message {
Expand Down
Loading