-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAS Integration 4A - Supplier Maintenance Errors #3258
Comments
This was referenced May 13, 2024
36 tasks
38 tasks
Need to incorporate Name and SIN updates on SIMS into error handling to resolve manually with CAS. |
Closed
17 tasks
35 tasks
@CarlyCotton we will disable the "Retry" if there is already a pending record created. |
@andrewsignori-aot That works. Can we be specific and say "Pending supplier verification" status? |
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 22, 2024
DB migration and model update for column - errors in table cas_suppliers. ![image](https://github.com/user-attachments/assets/085d0fb1-6a5b-4a3e-8cfd-615a8e7947ee) ![image](https://github.com/user-attachments/assets/7a67b660-a9de-4c72-94b5-227ca59fdde9) --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 5, 2024
1. Captured the prevalidation errors when it happens during the CAS calls and saved it in the cas_suppliers table with supplierStatus - ManualIntervention. > Given name required for creation. > Address outside of Canada cannot be processed. 2. Captured the know errors during the CAS service calls and saved it in the cas_suppliers table with supplierStatus - ManualIntervention. The know errors are split by "|" and saved as list in the error column in cas_suppliers table. > createSupplierAndSite > createSiteForExistingSupplier > getSupplierInfoFromCAS 3. E2E test cases were created for the error capture for the above know error and existing E2E is changed to capture the prevalidation error. --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 9, 2024
CAS errors are shown in the row expander of the CAS Supplier Information table. ![image](https://github.com/user-attachments/assets/2679c99c-7fe0-4b35-adcb-fb715f3278fc) E2E test case is created and existing is updated for the changed API. Failure in the sonarcloud is due to code duplication but I am not able to find the duplication in the code submitted in this PR. --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 11, 2024
Retry button is disabled, if the student already has a supplier in Pending supplier verification. ![image](https://github.com/user-attachments/assets/9d3d0bfe-87ce-469a-8a20-5af1546ceaac) Retry enabled when student does not have a Pending supplier verification. ![image](https://github.com/user-attachments/assets/6624430f-bcdb-4ada-8550-9b32d6156108) Retry will create a new record in cas_suppliers table with status as PendingSupplierVerification. --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 11, 2024
Trim function was called after the split, it should have been called before it. ![image](https://github.com/user-attachments/assets/c3886867-cb91-4525-97a1-818eea9cf36c) --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 12, 2024
CAS supplier errors enhancement and Unit Test ![image](https://github.com/user-attachments/assets/e5783859-7e16-4e8a-abf4-91378c423971) --------- Co-authored-by: guru-aot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 12, 2024
The create student action happening when Ministry user trying to approve a student. The SIN validation table is not inserted. This causes the search to fail as it uses the below query to fetch. ![image](https://github.com/user-attachments/assets/d0138e14-e475-478e-9435-cbf944db3ebf) This is a bug created during the cas supplier pending verification logic centralization that happened in the #3258 ticket. Co-authored-by: guru-aot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User Story
As a Ministry user, I need to know if SIMS could not successfully verify and assign a supplier number and site, this could be due to an identified manual intervention requirement or due to an error with the request to CAS. This needs to provide me context in which this occurred so I know if I can retry or resolve it. Retrying involves asking SIMS to attempt the action again with the current information (eventually). Resolving means that I have reviewed CAS and SIMS, making any necessary updates in either system and SIMS will not need to attempt the action again. This information will be used to create UI or populate a report.
Acceptance Criteria
User should see the response message for any CAS error or manual intervention pre-validation error records.
If Manual Intervention is required the associated Error message based on the situation:
For error responses from CAS set the status to "Manual Intervention" include the Error Message received from CAS (it comes in as a string, multiple are split by bars. See CAS 2A)
Any of these errors should make the Supplier
isValid = false
and in cases where Supplier found but create Site failed, save any valid Supplier infoRetry button means creating a new pending CAS request and is only available to the
business-administrator
group (can be linked to the existing cas-edit-supplier role)Include all error responses, including those from GetSupplier requests.
Business Context
Technical
errors
.The text was updated successfully, but these errors were encountered: