Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4087 - Search Student Bug #4089

Merged
merged 1 commit into from
Dec 12, 2024
Merged

#4087 - Search Student Bug #4089

merged 1 commit into from
Dec 12, 2024

Conversation

guru-aot
Copy link
Collaborator

The create student action happening when Ministry user trying to approve a student. The SIN validation table is not inserted. This causes the search to fail as it uses the below query to fetch.

image

This is a bug created during the cas supplier pending verification logic centralization that happened in the #3258 ticket.

@guru-aot guru-aot self-assigned this Dec 12, 2024
@guru-aot guru-aot added Bug Something isn't working SIMS-Api SIMS-Api labels Dec 12, 2024
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.94% ( 3786 / 17255 )
Methods: 9.99% ( 219 / 2192 )
Lines: 25.29% ( 3281 / 12971 )
Branches: 13.67% ( 286 / 2092 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80% ( 1336 / 1670 )
Methods: 63.55% ( 136 / 214 )
Lines: 83.49% ( 1123 / 1345 )
Branches: 69.37% ( 77 / 111 )

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good 👍

@lewischen-aot lewischen-aot self-requested a review December 12, 2024 23:10
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice debug 👍

@guru-aot guru-aot added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 36c0bdd Dec 12, 2024
21 checks passed
@guru-aot guru-aot deleted the feature/#4087-Search_Student_Bug branch December 12, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SIMS-Api SIMS-Api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants