Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3258 - CAS Supplier Retry operation #4053

Merged
merged 25 commits into from
Dec 11, 2024

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Dec 9, 2024

Retry button is disabled, if the student already has a supplier in Pending supplier verification.
image

Retry enabled when student does not have a Pending supplier verification.
image

Retry will create a new record in cas_suppliers table with status as PendingSupplierVerification.

@guru-aot guru-aot added User Experience task that relates to UI UX SIMS-Api SIMS-Api E2E/Unit tests labels Dec 9, 2024
@guru-aot guru-aot self-assigned this Dec 9, 2024
@guru-aot guru-aot marked this pull request as ready for review December 9, 2024 21:36
@andrewsignori-aot andrewsignori-aot self-requested a review December 9, 2024 22:21
/**
* Creates a new CAS Supplier for a student.
* @param studentId student id.
* @param auditUser user.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to auditUserId.

* Creates a new CAS Supplier for a student.
* @param studentId student id.
* @param auditUser user.
* @param entityManager optional entity manager.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust to options.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.95% ( 3754 / 17104 )
Methods: 10.09% ( 215 / 2131 )
Lines: 25.29% ( 3259 / 12884 )
Branches: 13.4% ( 280 / 2089 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.94% ( 1342 / 1580 )
Methods: 83.33% ( 135 / 162 )
Lines: 86.45% ( 1129 / 1306 )
Branches: 69.64% ( 78 / 112 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, look good 👍

Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.27% ( 5902 / 8773 )
Methods: 64.85% ( 725 / 1118 )
Lines: 71.24% ( 4635 / 6506 )
Branches: 47.17% ( 542 / 1149 )

Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍 Thanks for making the changes.

@guru-aot guru-aot added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit e6f505f Dec 11, 2024
21 checks passed
@guru-aot guru-aot deleted the feature/#3258_CAS_Supplier_Errors_Part4 branch December 11, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E/Unit tests SIMS-Api SIMS-Api User Experience task that relates to UI UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants