#3258 - CAS supplier errors enhancement and Unit Test #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 15:52
| }); | ||
|
|
||
| beforeEach(() => { | ||
| beforeEach(async () => { |
There was a problem hiding this comment.
The initialization should of the mocks should happen once and we should try to reset them.
If there is no other solution in sight right now we can consider moving forward with this.
Can you try the below one, please?
it("Should throw error when CAS API to create site for existing supplier with existing SIN payload data was provided.", async () => {
// Arrange
mockAuthenticationResponseOnce(httpService).mockResolvedValue({
data: {
SUPPLIER_NUMBER: "9999999",
SUPPLIER_SITE_CODE: "123",
},
});
const supplierData: CreateExistingSupplierSiteData = {
supplierNumber: "9999999",
emailAddress: "[email protected]",
supplierSite: {
addressLine1: "Street-Special Characters-ãñè-Maximum",
city: "City Name Over Maximum Length",
provinceCode: "BC",
postalCode: "h1h h2h",
},
};
//Act
httpService.axiosRef.post = jest.fn().mockImplementationOnce(() => {
const error = new AxiosError(
"Request failed with status code 400",
"ERR_BAD_REQUEST",
{
headers: new AxiosHeaders(),
},
{},
{
status: HttpStatusCode.BadRequest,
statusText: "Bad Request",
headers: new AxiosHeaders(),
config: { headers: new AxiosHeaders() },
data: {
"CAS-Returned-Messages":
"[0034] SIN is already in use. | [9999] Duplicate Supplier , Reason: [0065]- Possible duplicate exists, please use online form",
},
},
);
throw error;
});
//Assert
await expect(
casService.createSiteForExistingSupplier(supplierData),
).rejects.toThrow(
expect.objectContaining({
message: "CAS Bad Request Errors",
name: CAS_BAD_REQUEST,
objectInfo: [
"[0034] SIN is already in use.",
"[9999] Duplicate Supplier , Reason: [0065]- Possible duplicate exists, please use online form",
],
}),
);
Comment on lines
263
to
265
| const casKnownErrorArray = casKnownErrors.split("|").map((error) => { | ||
| return error.trim(); | ||
| }); |
There was a problem hiding this comment.
Not a blocker, it can be simplified as below.
const casKnownErrorArray = casKnownErrors
.split("|")
.map((error) => error.trim());`| @@ -64,4 +66,60 @@ describe("CASService-createSiteForExistingSupplier", () => { | |||
| DEFAULT_CAS_AXIOS_AUTH_HEADER, | |||
| ); | |||
| }); | |||
|
|
|||
| it("Should throw error when CAS API to create site for existing supplier with existing SIN payload data was provided.", async () => { | |||
There was a problem hiding this comment.
Can you please adjust the test description as below?
Should throw error when CAS API to create site for existing supplier with existing SIN payload data was provided and some CAS validation failed.
|
andrewsignori-aot
approved these changes
Dec 12, 2024
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS supplier errors enhancement and Unit Test