#3258 - Bug in the Error creation of CAS Supplier #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E SIMS API Coverage Report
|
andrepestana-aot
approved these changes
Dec 11, 2024
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
| throw new CustomNamedError( | ||
| "CAS Bad Request Errors", | ||
| CAS_BAD_REQUEST, | ||
| casKnownErrors.split(" | ").trim(), | ||
| casKnownErrors.trim().split(" | "), |
There was a problem hiding this comment.
To be clear, that was not what I meant when I said to trim().
There was a problem hiding this comment.
The string "Error 1 | Error 2" should be splitter by "|".
Then the results will be "Erro 1 " and " Error 2", those should have the trim() applied.
I also mentioned to have one unit test about it before the ticket was delivered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trim function was called after the split, it should have been called before it.
