Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3258 - CAS supplier errors - DB Migration - Part 1 #3991

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Nov 22, 2024

DB migration and model update for column - errors in table cas_suppliers.
image

image

@guru-aot guru-aot changed the title #3258 - CAS supplier errors - DB Migration #3258 - CAS supplier errors - DB Migration - Part 1 Nov 22, 2024
@guru-aot guru-aot self-assigned this Nov 22, 2024
@guru-aot guru-aot added the DB DB migration involved label Nov 22, 2024
Copy link
Collaborator

@bidyashish bidyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

ALTER TABLE
sims.cas_suppliers
ADD
COLUMN errors VARCHAR(300) [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The business has a list of all possible errors. Since this is not under our control I would suggest checking the list or increasing the number.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the error pdf, the max length error is 110 characters, so i think we are safe.

ADD
COLUMN errors VARCHAR(300) [];

COMMENT ON COLUMN sims.cas_suppliers.errors IS 'Errors received from CAS.';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust to "Errors while execution CAS verifications.".
The errors will also be generated by SIMS even without calling CAS.

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, please take a look in the minor comments.

Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.03% ( 3718 / 16875 )
Methods: 10.17% ( 214 / 2105 )
Lines: 25.36% ( 3226 / 12719 )
Branches: 13.55% ( 278 / 2051 )

Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@guru-aot guru-aot added this pull request to the merge queue Nov 22, 2024
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 84.17% ( 1234 / 1466 )
Methods: 83.8% ( 119 / 142 )
Lines: 85.44% ( 1050 / 1229 )
Branches: 68.42% ( 65 / 95 )

Merged via the queue into main with commit 270fa63 Nov 22, 2024
19 checks passed
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 66.94% ( 5774 / 8625 )
Methods: 64.8% ( 718 / 1108 )
Lines: 70.87% ( 4531 / 6393 )
Branches: 46.71% ( 525 / 1124 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB DB migration involved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants