-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3258 - CAS supplier errors - DB Migration - Part 1 #3991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
ALTER TABLE | ||
sims.cas_suppliers | ||
ADD | ||
COLUMN errors VARCHAR(300) []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The business has a list of all possible errors. Since this is not under our control I would suggest checking the list or increasing the number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of the error pdf, the max length error is 110 characters, so i think we are safe.
ADD | ||
COLUMN errors VARCHAR(300) []; | ||
|
||
COMMENT ON COLUMN sims.cas_suppliers.errors IS 'Errors received from CAS.'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust to "Errors while execution CAS verifications.".
The errors will also be generated by SIMS even without calling CAS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, please take a look in the minor comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
DB migration and model update for column - errors in table cas_suppliers.
