Add custom erc20 contract to the EVM.#53
Conversation
To compile the EVM it is required to compile ERC20 first if this change is used. Do this using the following steps: cd eth-contracts yarn yarn compile This will generate relevant binary in: `eth-contracts/res/EvmErc20.bin`
|
@mfornet Don't introduce new top-level directories, put |
Sounds good to me. Actually I was thinking if we should even keep this solidity contract here or in separate repository and only pull binary. I figured out it is better to have it here, since it is a small contract designed for be deployed as template by the evm. Note that this includes those bytes in the evm binary, so the size will increase considerably. |
|
Looks like CI needs to be updated to accommodate this? |
I wouldn't put it under |
|
Check tests |
|
And lints :D |
|
I created an issue for myself to make use of this contract in the benchmarks after it is merged instead of the generic ERC20. We might as well measure the implementation we are actually going to use. |
|
@mfornet Looking forward to merging this. Please reassign to me once CI is showing green and it's ready to go. |
Let's be clear that these precompiles are blockers for implementing and validating the connectors and hence blockers the release, and nice-to-haves like lints are a low priority right now. |
* Add custom erc20 contract to the EVM. To compile the EVM it is required to compile ERC20 first if this change is used. Do this using the following steps: cd eth-contracts yarn yarn compile This will generate relevant binary in: `eth-contracts/res/EvmErc20.bin` * Move eth contract to etc and update Makefile * Fix CI * Add lint
* Add custom erc20 contract to the EVM. To compile the EVM it is required to compile ERC20 first if this change is used. Do this using the following steps: cd eth-contracts yarn yarn compile This will generate relevant binary in: `eth-contracts/res/EvmErc20.bin` * Move eth contract to etc and update Makefile * Fix CI * Add lint
4 participants
To compile the EVM it is required to compile ERC20 first if this change is used. Do this using the following steps:
This will generate relevant binary in:
eth-contracts/res/EvmErc20.bin