Pass state to precompiles#34
Merged
Merged
Conversation
20 tasks
sorpaas
reviewed
Jun 10, 2021
sorpaas
approved these changes
Jun 10, 2021
Member
|
I'm going to temporarily revert this PR, since it conflicts with some other requirements needed at this moment to support fully customizable precompiles. I think the correct way to try to do what you are doing is through a custom Executor interface where you can add all additional parameters you need. Right now this requires duplicating some code, but I'll work on fixing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let precompiles have access to the state, and be aware whether the they were invoked in a static call or not.
We need this for Aurora since some precompiles trigger some behaviour in NEAR blockchain that needs to be tracked. The current interface of the state is used, to revert this behaviour in case the function call inside the EVM is also reverted.