Pull in PRs from sylabs/singularity 3.8.2 release #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometime the Debian arch string is not identical to the `runtime.GOARCH` value for a platform. Map from `runtime.GOARCH` to the Debian arch to address this. Fixes: singularity-ce apptainer#204
When the destination of a line in the `%files` section is ommitted, the file should be copied to the same full path within the destination rootfs as it is in the source. Previously we naively set dst = src in this case, but src might be a globbing pattern. In this case the file copy destination was the glob pattern, not the matched path(s) after globbing. Handle a blank "" dest in the CopyFromHost / CopyFromStage functions, where globbing occurs. Copy to the correct full path after globbing. Update tests to capture this behavior. Fixes apptainer#196
`singularity delete` would accept a hostname in the library:// URI provided, but would perform the request against the default remote. Fix this, so it is handled in the same way as for push/pull. Fixes singularity-ce apptainer#243
Be much more explicit in what a remote endpoint is vs OCI credentials. Generally expand the descriptive text.
Repeated `remote login` with the same URI can cause duplicate `Credentials` entries in `~/remote.yaml`. Ensure a `remote login` with an existing configured URI replaces the existing entry. Make `remote logout` remove all entries to clean up the result of this bug. Fixes apptainer#214
The Sylabs lolcow image has been modified so that it no longer uses `fortune`, which produced offensive output. Ensure all references to a lolcow image are to the fixed Sylabs version. Fixes apptainer#248
If the system page size is not 2MB just test cgroups without a hugetlb limit, rather than putting in more complex logic to work up configs for different page sizes. Fixes #9
When the source in a `%files` entry is a glob that matches multiple files, and the destination is `""`, make sure we always set the correct real destination for each file. Fixes apptainer#261
We were previously setting `--user-xattrs` / `--no-xattrs` based on the current euid when calling `unsquashfs`. However, in a non-setuid install `--fakeroot` build the euid is 0, so the flags will not be set. On distributions other than EL / Fedora (i.e. Debian / Ubuntu which are not selinux native), this can cause failed extraction. Decide if we are performing a rootless extraction based on the host uid, outside of any namespace that is in play. Fixes: apptainer#266
kmuriki
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks commits from these Sylabs PRs that went into singularity-ce 3.8.2
%filessylabs/singularity#197remote.yamlentries from multiple login sylabs/singularity#216singularity deletesylabs/singularity#244singularity buildsylabs/singularity#253Fixes #6128
Fixes #6113