Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: skip hugetlb cgroup limit for non-2MB page size #209

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Aug 3, 2021

Description of the Pull Request (PR):

If the system page size is not 2MB just test cgroups without a hugetlb
limit, rather than putting in more complex logic to work up configs for
different page sizes.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

@dtrudg dtrudg added bug Something isn't working testing labels Aug 3, 2021
@dtrudg dtrudg added this to the SingularityCE 3.9.0 milestone Aug 3, 2021
@dtrudg dtrudg self-assigned this Aug 3, 2021
@dtrudg dtrudg added the ppc64le label Aug 3, 2021
@dtrudg dtrudg marked this pull request as ready for review August 3, 2021 18:09
@dtrudg dtrudg force-pushed the issue9 branch 2 times, most recently from 9897381 to 328a88a Compare August 6, 2021 21:03
If the system page size is not 2MB just test cgroups without a hugetlb
limit, rather than putting in more complex logic to work up configs for
different page sizes.

Fixes #9
@dtrudg dtrudg merged commit 7c4ab2c into sylabs:master Aug 9, 2021
@dtrudg dtrudg deleted the issue9 branch August 9, 2021 14:05
dtrudg added a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ppc64le testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EL8 ppc64le FAIL: TestCgroups
2 participants