py2/py3 compatibility for urllib/urllib2 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation at http://singularity.lbl.gov/docs-exec shows running this example $ singularity exec docker://python:latest /usr/local/bin/python hello.py Doing so with python3 as default python interpreter brings up an error as urllib2 is python2 only: ImportError: No module named 'urllib2' This is a change to make the code py2/py3 compatible
|
Hi @alaindomissy, this looks good to me but it is @vsoch's code so I want her thumbs up too. Thanks! |
|
Actually, I still have a problem with python3. I now get this error : |
|
I can fix this up this weekend - just did this exact thing for another project actually! |
in python3 urllib.request.Request.read() returns a bytes object this is a change to decode
|
There was another python3 issue. It is now working for me in both py2 and py3. |
|
ok, this looks good. It would be good to have some tests for this, but it doesn't hurt to fix the incompatibility even without. Thanks for your help doing this! |
DrDaveD
pushed a commit
to DrDaveD/singularity
that referenced
this pull request
Aug 25, 2021
We were previously setting `--user-xattrs` / `--no-xattrs` based on the current euid when calling `unsquashfs`. However, in a non-setuid install `--fakeroot` build the euid is 0, so the flags will not be set. On distributions other than EL / Fedora (i.e. Debian / Ubuntu which are not selinux native), this can cause failed extraction. Decide if we are performing a rootless extraction based on the host uid, outside of any namespace that is in play. Fixes: apptainer#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation at http://singularity.lbl.gov/docs-exec shows running this example
$ singularity exec docker://python:latest /usr/local/bin/python hello.py
Doing so with python3 as default python interpreter brings up an error as urllib2 is python2 only:
ImportError: No module named 'urllib2'
This is a change to make the code py2/py3 compatible