Null terminate envar result, and don't lose track of malloc #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you! |
DrDaveD
pushed a commit
to DrDaveD/singularity
that referenced
this pull request
Aug 25, 2021
The Sylabs lolcow image has been modified so that it no longer uses `fortune`, which produced offensive output. Ensure all references to a lolcow image are to the fixed Sylabs version. Fixes apptainer#248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a -B on to a singularity exec with -C and without without -W, I was getting fatal errors that it was trying to bind something that didn't exist. I tracked it down to a missing null terminator in the envar function. This pull request fixes the problem. While there I noticed it was also possible for the function to malloc some space and lose track of it.