Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`--version' does not say it all #196

Closed
czka opened this issue Aug 28, 2016 · 1 comment
Closed

`--version' does not say it all #196

czka opened this issue Aug 28, 2016 · 1 comment

Comments

@czka
Copy link
Contributor

czka commented Aug 28, 2016 

$ singularity --version
2.1

Expecting 2.1.2 here, as that was the version I have installed.
@gmkurtzer
Copy link
Contributor

Yep, you are right. Fixed in [2.x 50b322c].

DrDaveD pushed a commit to DrDaveD/singularity that referenced this issue Aug 25, 2021
@dtrudg @DrDaveD
Copy globbed files to correct destination in %files
a1055eb 
When the destination of a line in the `%files` section is ommitted, the
file should be copied to the same full path within the destination
rootfs as it is in the source.

Previously we naively set dst = src in this case, but src might be a
globbing pattern. In this case the file copy destination was the glob
pattern, not the matched path(s) after globbing.

Handle a blank "" dest in the CopyFromHost / CopyFromStage functions,
where globbing occurs. Copy to the correct full path after globbing.
Update tests to capture this behavior.

Fixes apptainer#196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@czka @gmkurtzer