fix: Config for dataset health check#12906
Merged
ktmud merged 2 commits intoapache:masterfrom Feb 3, 2021
Merged
Conversation
| logger.exception("Found but failed to import local superset_config") | ||
| raise | ||
|
|
||
| # It's possible to add a dataset health check logic which is specific to your system. |
Author
There was a problem hiding this comment.
config listed below the overwrite function won't be overwritten. Have to move it up.
Member
There was a problem hiding this comment.
Maybe add a comment block here to stop others from adding new config below this line?
# -------------------------------------------------------------------
# * WARNING: STOP EDITING HERE *
# -------------------------------------------------------------------
# Don't add config values below this line since local configs won't be
# able to override them.
Member
There was a problem hiding this comment.
+1 for that warning, we've seen issues with config values being added after overrides are loaded.
| data_["template_params"] = self.template_params | ||
| data_["is_sqllab_view"] = self.is_sqllab_view | ||
| data_["health_check_message"] = self.health_check_message | ||
| data_["health_check_message"] = ( |
Author
There was a problem hiding this comment.
Should not return health check message, when feature is disabled but had populated health check message before.
Member
There was a problem hiding this comment.
Maybe add this comment to code as well?
# Don't return previously populated health check message in case
# the health check feature is turned off
ktmud
approved these changes
Feb 3, 2021
Member
ktmud
left a comment
ktmud
left a comment
There was a problem hiding this comment.
LGTM with some suggestions for code comments
Codecov Report
@@ Coverage Diff @@
## master #12906 +/- ##
==========================================
- Coverage 66.97% 63.42% -3.56%
==========================================
Files 1026 490 -536
Lines 50330 30256 -20074
Branches 5242 0 -5242
==========================================
- Hits 33711 19189 -14522
+ Misses 16485 11067 -5418
+ Partials 134 0 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
approved these changes
Feb 3, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 3, 2021
* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Feb 3, 2021
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Found a couple issues when I tried to enable dataset health check in airbnb.
TEST PLAN
CI and manual test
ADDITIONAL INFORMATION