refactor: Bootstrap to AntD - Label#12774
Merged
rusackas merged 1 commit intoapache:masterfrom Feb 2, 2021
Merged
Conversation
michael-s-molina
force-pushed
the
bootstrap-to-antd-label
branch
from
d6a01b7 to
656fec2
Compare
Codecov Report
@@ Coverage Diff @@
## master #12774 +/- ##
==========================================
- Coverage 66.99% 63.38% -3.62%
==========================================
Files 1022 488 -534
Lines 50049 30127 -19922
Branches 4914 0 -4914
==========================================
- Hits 33532 19096 -14436
+ Misses 16393 11031 -5362
+ Partials 124 0 -124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Jan 27, 2021
rusackas
reviewed
Jan 27, 2021
rusackas
reviewed
Jan 27, 2021
rusackas
requested changes
Jan 27, 2021
Member
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
This is looking fantastic! Ready to approve, but would like to change that bsStyle prop name.
michael-s-molina
force-pushed
the
bootstrap-to-antd-label
branch
from
656fec2 to
993024c
Compare
Contributor
|
I can see that Database label is a little bit moved. On master is straight. |
michael-s-molina
force-pushed
the
bootstrap-to-antd-label
branch
from
993024c to
be737c2
Compare
Member
Author
|
@adam-stasiak Thank you so much for reviewing! Fixed! |
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 3, 2021
* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...
8 tasks
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
bsStyleproperty totypeand add typescript checking.See: #10254
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
@rusackas @junlincc
TEST PLAN
1 - Open any screen that contains a label (explore, profile, dashboards, etc.)
2 - All labels should have the same theme and behavior
3 - Additional testing can be done using Storybook
ADDITIONAL INFORMATION