fix(chart): allow null for optional query object props

[ktmud]

SUMMARY

This is probably a little controversial, too.

Sometimes chart plugin buildQuery generates invalid null values for certain props (either because of sloppy code or uncleaned legacy data), making the whole query fails:

Since most of the props are optional anyway, maybe we should just make the backend more error-tolerant by allowing null (None) everywhere possible.

TEST PLAN

• Added a unit test to check a query with granularity: null can still load and it has the same cache key as when granularity is not set.`

• Manually tested by sending API request with null values to /api/v1/chart/data

{
	"datasource": {
		"id": 27,
		"type": "table"
	},
	"force": false,
	"queries": [
		{
			"time_range": null,
			"filters": null,
			"columns": [
				"season",
				"episode",
				"TITLE"
			],
			"metrics": null,
			"orderby": null,
			"row_limit": null,
			"timeseries_limit": null,
			"order_desc": null,
			"url_params": null,
			"post_processing": null
		}
	],
	"result_format": "json",
	"result_type": "full"
}

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[betodealmeida]

I think is good. In general I try to follow Postel's Law: "Be conservative in what you send, be liberal in what you accept"

[ktmud]

That's a good quote!

[codecov-io]

Codecov Report

Merging #12905 (6c4a999) into master (5a79a7d) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12905      +/-   ##
==========================================
- Coverage   66.98%   66.56%   -0.43%     
==========================================
  Files        1026     1026              
  Lines       50330    50744     +414     
  Branches     5189     5361     +172     
==========================================
+ Hits        33713    33777      +64     
- Misses      16483    16832     +349     
- Partials      134      135       +1     

Flag	Coverage Δ
cypress	50.82% <ø> (+0.01%)	⬆️
javascript	61.83% <ø> (ø)
python	63.95% <100.00%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/charts/schemas.py	100.00% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	44.81% <0.00%> (-19.09%)	⬇️
superset/db_engine_specs/presto.py	82.25% <0.00%> (-6.28%)	⬇️
superset/db_engine_specs/sqlite.py	90.62% <0.00%> (-6.25%)	⬇️
...et-frontend/src/SqlLab/reducers/getInitialState.js	46.42% <0.00%> (-3.58%)	⬇️
superset/utils/celery.py	86.20% <0.00%> (-3.45%)	⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js	37.59% <0.00%> (-2.49%)	⬇️
superset/db_engine_specs/mysql.py	89.79% <0.00%> (-2.05%)	⬇️
superset/result_set.py	96.69% <0.00%> (-1.66%)	⬇️
superset/models/core.py	87.77% <0.00%> (-1.09%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a79a7d...6c4a999. Read the comment docs.