Skip to content

fix: allow users to reset their passwords#12886

Merged
dpgaspar merged 1 commit intoapache:masterfrom
preset-io:fix/reset-password-perm
Feb 2, 2021
Merged

fix: allow users to reset their passwords#12886
dpgaspar merged 1 commit intoapache:masterfrom
preset-io:fix/reset-password-perm

Conversation

@dpgaspar
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar commented Feb 2, 2021

SUMMARY

Allows users to reset their own passwords (When DB auth is enabled)

Follow up for: #12877

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2021-02-02 at 10 53 29

After:
Screenshot 2021-02-02 at 10 51 49

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 2, 2021

Codecov Report

Merging #12886 (2f94de2) into master (2adfb85) will decrease coverage by 1.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12886      +/-   ##
==========================================
- Coverage   64.89%   63.69%   -1.21%     
==========================================
  Files        1024      489     -535     
  Lines       50168    30199   -19969     
  Branches     5148        0    -5148     
==========================================
- Hits        32557    19235   -13322     
+ Misses      17433    10964    -6469     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress ?
javascript ?
python 63.69% <100.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 91.01% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 73.84% <0.00%> (-17.31%) ⬇️
superset/db_engine_specs/presto.py 81.38% <0.00%> (-7.15%) ⬇️
superset/db_engine_specs/mysql.py 89.79% <0.00%> (-2.05%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.22% <0.00%> (-1.64%) ⬇️
superset/views/core.py 74.98% <0.00%> (-0.45%) ⬇️
superset/connectors/sqla/models.py 90.45% <0.00%> (-0.14%) ⬇️
superset-frontend/src/components/IconTooltip.tsx
... and 533 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941d924...2f94de2. Read the comment docs.

@dpgaspar dpgaspar merged commit 9cc38ac into apache:master Feb 2, 2021
@dpgaspar dpgaspar deleted the fix/reset-password-perm branch February 2, 2021 15:19
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 3, 2021
* master: (23 commits)
  feat(explore): clear search on dataset change (apache#12909)
  chore: remove SIP-38 feature flag (apache#12894)
  fix: Config for dataset health check (apache#12906)
  fix(chart): allow null for most query object props (apache#12905)
  feat: add separate endpoint to fetch function names for autocomplete (apache#12840)
  chore: add required review on master (apache#12694)
  fix: comment typo (apache#12898)
  Migrates Radio component from Bootstrap to AntD. (apache#12738)
  fix: allow users to reset their passwords (apache#12886)
  fix(explore): missing select when groupby without metrics (apache#12890)
  refactor: dbapi exception mapping for dbapi's (apache#12869)
  feat(style-theme): add support for custom superset themes (apache#12858)
  chore(lint): fix pre-commit error (apache#12884)
  refactor(color-schemes): refactor setting of color schemes (apache#12857)
  feat(native-filters): Add defaultValue for Native filters modal (apache#12199)
  feat(release): add github token to changelog script (apache#12872)
  fix(menu): always show settings dropdown (apache#12877)
  Migrates Label component from Bootstrap to AntD. (apache#12774)
  [Helm] Automate datasource import (apache#10771)
  build: Skip loading example data from configs in CI (apache#12610)
  ...
@mistercrunch mistercrunch added 🍒 1.0.1 Cherry-picked to 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S v1.0.1 🍒 1.0.1 Cherry-picked to 1.0.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants