[Helm] Automate datasource import

[ejianu]

SUMMARY

Helm chart change: Added 2 possible properties which will essentially automate the creation of database connections in superset.

Changes in the values file:
extraConfigs to which we can pass a yaml file that we exported previously, that defines a datasource.
extraConfigMountPath location at which this file will be

Changes in the chart:

Added a configMap template file that only creates the ConfigMap if the extraConfigs is set.
In the init-job file, the new "extra-config" volume is mounted only if extraConfigs is set.

In this way, the original approach should not be affected.

TEST PLAN

1. Make sure you create a datasource in the interface and export it to yaml, then delete it and check it was deleted.
2. In the values file set the yaml you exported, this is an example, but any datasource exported yaml should do:

extraConfigs: 
  datasources.yaml: | 
      databases:
      - allow_csv_upload: true
        allow_ctas: true
        allow_cvas: true
        database_name: presto
        extra: "{\r\n    \"metadata_params\": {},\r\n    \"engine_params\": {},\r\n    \"\
          metadata_cache_timeout\": {},\r\n    \"schemas_allowed_for_csv_upload\": []\r\n\
          }"
        sqlalchemy_uri: presto://presto.whatever
        tables: []

3. set the following property, the datasource file will be mounted at some location:
   extraConfigMountPath: "/app/configs"

4. under the Init job configuration in the init script add a command that imports the file we defined previously:
   echo "Initializing connection.... "
   superset import_datasources -p {{ .Values.extraConfigMountPath }}/datasources.yaml

5. Check if the datasource was imported correctly.

[craig-rueda]

One quick thing, otherwise LGTM

[craig-rueda]

Can you pipe the val to tpl?

So, {{ tpl $config . | indent 4 -}}

[ejianu]

Changes made :)

[willbarrett]

Please trim trailing whitespace to fix the precommit hook, after that should be good to merge.

[nytai]

Suggested change

	affinity: {}
	affinity: {}

[nytai]

Suggested change

	{{- end -}}
	{{- end -}}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[andreas-repp]

What is the status on these changes? I'd really like to see them integrated.

[zhmurko]

if someone is looking why import with extraConfigs does not work, just add into initscript a command:

        echo "Initializing connection.... "
        superset import_datasources -p {{ .Values.extraConfigMountPath }}/datasources-init.yaml

this step is not present in master branch at this moment.

[jawabuu]

@ejianu @craig-rueda I have noticed that databases imported in this manner do not mask the password value like the ones added in the UI. Is this expected?