refactor: Bootstrap to AntD - Radio#12738
Merged
rusackas merged 1 commit intoapache:masterfrom Feb 2, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12738 +/- ##
==========================================
- Coverage 65.05% 59.23% -5.82%
==========================================
Files 1021 964 -57
Lines 50095 47327 -2768
Branches 5141 4436 -705
==========================================
- Hits 32587 28036 -4551
- Misses 17332 19291 +1959
+ Partials 176 0 -176
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
reviewed
Jan 25, 2021
Member
junlincc
left a comment
junlincc
left a comment
There was a problem hiding this comment.
looked through all the button changes in the product. ✅ thanks for the migration work!
Contributor
|
I went through them as well + Multiple browsers 🟢 |
michael-s-molina
force-pushed
the
bootstrap-to-antd-radio
branch
from
ca2579d to
756ff61
Compare
villebro
reviewed
Jan 27, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM, one minor nit. One step closer to dropping react-bootstrap 🙂
superset-frontend/src/common/components/Radio/Radio.stories.tsx
Outdated
Show resolved
Hide resolved
michael-s-molina
force-pushed
the
bootstrap-to-antd-radio
branch
from
756ff61 to
50ee218
Compare
villebro
approved these changes
Jan 27, 2021
rusackas
reviewed
Jan 29, 2021
rusackas
approved these changes
Jan 29, 2021
Member
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
One minor nit looking for every reasonable use case for gridUnit, but this PR looks great, so I'm stampin' it and will circle back to merge soon either way! One more down!
michael-s-molina
force-pushed
the
bootstrap-to-antd-radio
branch
from
50ee218 to
847c3aa
Compare
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 3, 2021
* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
See: #10254
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
@rusackas @junlincc
TEST PLAN
1 - Open any screen that contains a radio button (explore -> save chart, explore -> edit dataset, etc.)
2 - All radio buttons should have the same theme and behavior
ADDITIONAL INFORMATION