[SPARK-41217][SQL] Add the error class FAILED_FUNCTION_CALL
#38744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
FAILED_FUNCTION_CALLFAILED_FUNCTION_CALL
Member
Author
|
@panbingkun @LuciferYang @itholic @cloud-fan @srielau Could you review this PR, please. |
MaxGekk
commented
Nov 21, 2022
|
|
||
| def funcBuildError(funcName: String, cause: Exception): Throwable = { | ||
| cause.getCause match { | ||
| case st: SparkThrowable with Throwable => st |
Member
Author
There was a problem hiding this comment.
If some Spark's exception happens during preparation of a function call, we just propagate it to users AS IS otherwise (something we didn't catch) we wrap it by AnalysisException(errorClass = FAILED_FUNCTION_CALL)
Member
Author
|
@panbingkun @LuciferYang Your PRs are related to this one. I would propose to merge this first of all to properly propagate
@cloud-fan We bypass |
LuciferYang
approved these changes
Nov 22, 2022
Contributor
LuciferYang
left a comment
LuciferYang
left a comment
There was a problem hiding this comment.
+1, LGTM
I think we can merge this as soon as possible
Contributor
|
+1, LGTM |
panbingkun
approved these changes
Nov 22, 2022
cloud-fan
approved these changes
Nov 22, 2022
Member
Author
|
Merging to master. Thank you, @panbingkun @LuciferYang @cloud-fan for review. |
Contributor
|
OK, I will rebase my pr |
Member
Author
|
@panbingkun Please, update your PRs. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? In the PR, I propose new error class `FAILED_FUNCTION_CALL` for errors that might occur while preparing functions class, for instance during creation of expression instances. Also, the PR propagates `SparkThrowable` to users in handling any exceptions coming from preparations of functions calls. ### Why are the changes needed? To improve user experience with Spark SQL, in particular, the PR makes errors more clear. ### Does this PR introduce _any_ user-facing change? Yes, it affects the user-facing errors. ### How was this patch tested? By running the modified test suites: ``` $ build/sbt "core/testOnly *SparkThrowableSuite" $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38744 from MaxGekk/failed-builtin-func. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? In the PR, I propose new error class `FAILED_FUNCTION_CALL` for errors that might occur while preparing functions class, for instance during creation of expression instances. Also, the PR propagates `SparkThrowable` to users in handling any exceptions coming from preparations of functions calls. ### Why are the changes needed? To improve user experience with Spark SQL, in particular, the PR makes errors more clear. ### Does this PR introduce _any_ user-facing change? Yes, it affects the user-facing errors. ### How was this patch tested? By running the modified test suites: ``` $ build/sbt "core/testOnly *SparkThrowableSuite" $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38744 from MaxGekk/failed-builtin-func. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? In the PR, I propose new error class `FAILED_FUNCTION_CALL` for errors that might occur while preparing functions class, for instance during creation of expression instances. Also, the PR propagates `SparkThrowable` to users in handling any exceptions coming from preparations of functions calls. ### Why are the changes needed? To improve user experience with Spark SQL, in particular, the PR makes errors more clear. ### Does this PR introduce _any_ user-facing change? Yes, it affects the user-facing errors. ### How was this patch tested? By running the modified test suites: ``` $ build/sbt "core/testOnly *SparkThrowableSuite" $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38744 from MaxGekk/failed-builtin-func. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose new error class
FAILED_FUNCTION_CALLfor errors that might occur while preparing functions class, for instance during creation of expression instances. Also, the PR propagatesSparkThrowableto users in handling any exceptions coming from preparations of functions calls.Why are the changes needed?
To improve user experience with Spark SQL, in particular, the PR makes errors more clear.
Does this PR introduce any user-facing change?
Yes, it affects the user-facing errors.
How was this patch tested?
By running the modified test suites: