[SPARK-41181][SQL] Migrate the map options errors onto error classes #38730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@panbingkun Could you resolve conflicts, please. |
|
Can one of the admins verify this patch? |
Contributor
Author
Done. |
MaxGekk
reviewed
Nov 24, 2022
| "subClass" : { | ||
| "NON_STRING_TYPE" : { | ||
| "message" : [ | ||
| "A type of keys and values in map() must be string, but got <map>." |
| "A type of keys and values in map() must be string, but got <map>." | ||
| ] | ||
| }, | ||
| "NOT_MAP_FUNCTION" : { |
| messageParameters = Map("map" -> toSQLType(m.dataType))) | ||
| } | ||
|
|
||
| def nonMapFunctionNotAllowedError(): Throwable = { |
Member
There was a problem hiding this comment.
Be sure the names are consistent. not or non
| }, | ||
| "NOT_MAP_FUNCTION" : { | ||
| "message" : [ | ||
| "Must use a map() function for options." |
Member
There was a problem hiding this comment.
Suggested change
| "Must use a map() function for options." | |
| "Must use the `map()` function for options." |
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? The pr aims to migrate the map options errors onto error classes. ### Why are the changes needed? The changes improve the error framework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38730 from panbingkun/SPARK-41181. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? The pr aims to migrate the map options errors onto error classes. ### Why are the changes needed? The changes improve the error framework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38730 from panbingkun/SPARK-41181. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to migrate the map options errors onto error classes.
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.