[SPARK-41176][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1042 #38707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
MaxGekk
reviewed
Nov 22, 2022
| "The operation <statement> is not allowed on the <objectType>: <objectName>" | ||
| ] | ||
| }, | ||
| "FUNCTION_WRONG_NUM_ARGS" : { |
Member
There was a problem hiding this comment.
@cloud-fan @srielau Are you ok with the name or maybe just WRONG_NUM_ARGS? Later we will merge DATATYPE_MISMATCH.WRONG_NUM_ARGS into it.
Contributor
There was a problem hiding this comment.
WRONG_NUM_ARGs is fine. If we want to keep a longer name I'd prefer ROUTINE over FUNCTIOn for future proofing.
MaxGekk
requested changes
Nov 23, 2022
| "name" -> name, | ||
| "expectedInfo" -> expectedInfo, | ||
| "actualNumber" -> actualNumber.toString)) | ||
| "functionName" -> name, |
Member
There was a problem hiding this comment.
Please, wrap functionName by toSQLId().
MaxGekk
approved these changes
Nov 24, 2022
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…P_1042 ### What changes were proposed in this pull request? In the PR, I propose to assign a name to the error class _LEGACY_ERROR_TEMP_1042. ### Why are the changes needed? Proper names of error classes should improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38707 from panbingkun/SPARK-41176. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…P_1042 ### What changes were proposed in this pull request? In the PR, I propose to assign a name to the error class _LEGACY_ERROR_TEMP_1042. ### Why are the changes needed? Proper names of error classes should improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38707 from panbingkun/SPARK-41176. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to assign a name to the error class _LEGACY_ERROR_TEMP_1042.
Why are the changes needed?
Proper names of error classes should improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.