[SPARK-41182][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1102 #38725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Nov 20, 2022
| }, | ||
| "UNSUPPORTED_LITERAL_FOR_SOURCE_TYPE" : { | ||
| "message" : [ | ||
| "Literals of the type <field> are currently not supported for the <sourceDataType> type." |
Member
There was a problem hiding this comment.
Looking at where the error comes from:
, the error message and error class name confuse slightly. The error is mostly about an extract field. How about error class name:
INVALID_EXTRACT_FIELD
Also cc @srielau
Contributor
Author
There was a problem hiding this comment.
OK, Let me to do it.
|
Can one of the admins verify this patch? |
MaxGekk
requested changes
Nov 23, 2022
| }, | ||
| "INVALID_EXTRACT_FIELD" : { | ||
| "message" : [ | ||
| "Literals of the type <field> are currently not supported for the <sourceDataType> type." |
Member
There was a problem hiding this comment.
Could you make the error message more clear and precise. Let's talk specifically about the invalid extract field.
MaxGekk
approved these changes
Nov 24, 2022
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…P_1102 ### What changes were proposed in this pull request? In the PR, I propose to assign the name `INVALID_EXTRACT_FIELD` to the error class `_LEGACY_ERROR_TEMP_1102`. ### Why are the changes needed? Proper names of error classes should improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38725 from panbingkun/SPARK-41182. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…P_1102 ### What changes were proposed in this pull request? In the PR, I propose to assign the name `INVALID_EXTRACT_FIELD` to the error class `_LEGACY_ERROR_TEMP_1102`. ### Why are the changes needed? Proper names of error classes should improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes apache#38725 from panbingkun/SPARK-41182. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 23, 2024
### What changes were proposed in this pull request? This pr aims to upgrade Arrow from 14.0.2 to 15.0.0, this version fixes the compatibility issue with Netty 4.1.104.Final(GH-39265). Additionally, since the `arrow-vector` module uses `eclipse-collections` to replace `netty-common` as a compile-level dependency, Apache Spark has added a dependency on `eclipse-collections` after upgrading to use Arrow 15.0.0. ### Why are the changes needed? The new version brings the following major changes: Bug Fixes GH-34610 - [Java] Fix valueCount and field name when loading/transferring NullVector GH-38242 - [Java] Fix incorrect internal struct accounting for DenseUnionVector#getBufferSizeFor GH-38254 - [Java] Add reusable buffer getters to char/binary vectors GH-38366 - [Java] Fix Murmur hash on buffers less than 4 bytes GH-38387 - [Java] Fix JDK8 compilation issue with TestAllTypes GH-38614 - [Java] Add VarBinary and VarCharWriter helper methods to more writers GH-38725 - [Java] decompression in Lz4CompressionCodec.java does not set writer index New Features and Improvements GH-38511 - [Java] Add getTransferPair(Field, BufferAllocator, CallBack) for StructVector and MapVector GH-14936 - [Java] Remove netty dependency from arrow-vector GH-38990 - [Java] Upgrade to flatc version 23.5.26 GH-39265 - [Java] Make it run well with the netty newest version 4.1.104 The full release notes as follows: - https://arrow.apache.org/release/15.0.0.html ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44797 from LuciferYang/SPARK-46718. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to assign the name
INVALID_EXTRACT_FIELDto the error class_LEGACY_ERROR_TEMP_1102.Why are the changes needed?
Proper names of error classes should improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.