[SPARK-41174][CORE][SQL] Propagate an error class to users for invalid format of to_binary()
#38737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
format of to_binary()format of to_binary()
Contributor
Author
|
cc @MaxGekk |
Contributor
Author
|
@MaxGekk rebased |
srielau
approved these changes
Nov 22, 2022
MaxGekk
reviewed
Nov 23, 2022
| } | ||
| } else if (!f.foldable) { | ||
| DataTypeMismatch( | ||
| errorSubClass = "NON_FOLDABLE_INPUT", |
Member
There was a problem hiding this comment.
Could you write a test for the case, please. I just wonder how it could happen:
if (f.foldable && ...) {
...
} else if (!f.foldable) {
Contributor
Author
There was a problem hiding this comment.
For !f.foldable branch?
Member
There was a problem hiding this comment.
Yep. Just to be sure we handle the non-foldable case correctly.
MaxGekk
reviewed
Nov 23, 2022
| GenerateUnsafeProjection.generate(StringDecode(b, Literal("\"quote")) :: Nil) | ||
| } | ||
|
|
||
|
|
MaxGekk
approved these changes
Nov 23, 2022
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
LGTM except of a minor comment.
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…d `format` of `to_binary()` ### What changes were proposed in this pull request? This pr overrides the `checkInputDataTypes()` method of `ToBinary` function to propagate error class to users for invalid `format`. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38737 from LuciferYang/SPARK-41174. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…d `format` of `to_binary()` ### What changes were proposed in this pull request? This pr overrides the `checkInputDataTypes()` method of `ToBinary` function to propagate error class to users for invalid `format`. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? Pass GitHub Actions Closes apache#38737 from LuciferYang/SPARK-41174. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr overrides the
checkInputDataTypes()method ofToBinaryfunction to propagate error class to users for invalidformat.Why are the changes needed?
Migration onto error classes unifies Spark SQL error messages.
Does this PR introduce any user-facing change?
Yes. The PR changes user-facing error messages.
How was this patch tested?
Pass GitHub Actions