Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Nov 18, 2022

What changes were proposed in this pull request?

In the PR, I propose to assign the name INVALID_SCHEMA to the error class _LEGACY_ERROR_TEMP_1092.

Why are the changes needed?

Proper names of error classes should improve user experience with Spark SQL.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@MaxGekk
Copy link
Member

MaxGekk commented Nov 23, 2022

@panbingkun Please, resolve conflicts.

@panbingkun
Copy link
Contributor Author

@panbingkun Please, resolve conflicts.

Done.

@MaxGekk
Copy link
Member

MaxGekk commented Nov 24, 2022

+1, LGTM. Merging to master.
Thank you, @panbingkun.

@MaxGekk MaxGekk closed this in 074444b Nov 24, 2022
beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 15, 2022
…P_1092

### What changes were proposed in this pull request?
In the PR, I propose to assign the name `INVALID_SCHEMA` to the error class `_LEGACY_ERROR_TEMP_1092`.

### Why are the changes needed?
Proper names of error classes should improve user experience with Spark SQL.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes apache#38710 from panbingkun/SPARK-41179.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
…P_1092

### What changes were proposed in this pull request?
In the PR, I propose to assign the name `INVALID_SCHEMA` to the error class `_LEGACY_ERROR_TEMP_1092`.

### Why are the changes needed?
Proper names of error classes should improve user experience with Spark SQL.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes apache#38710 from panbingkun/SPARK-41179.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants