-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-4031. Run shell tests in CI #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 thanks the patch @adoroszlai
fun fact: I started to do the same during the last weekend, but this patch seems to be better.
As usual, I have some random thoughts added (I think it's good to have "water cooler conversations", and as everybody working from remote, PRs seems to be a good place to chat ;-) )
But none of them are blocker. Especially as I have other PRs with more bats tests, I would prefer to merge it as is, now.
|
|
||
| rm -f "${REPORT_DIR}/output.log" | ||
|
|
||
| find * -path '*/src/test/shell/*' -name '*.bats' -print0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussion-mode:on
This pattern ("fail at the end") is introduced to execute all the tests even if some of them are failing. It's very useful for long and flaky test runs.
But it's somewhat more complex.
Recently I started to think to use a "fail fast" approach. It can simplify the scripts and we can use set -e to be sure we don't ignore any internal errors.
It's not working everywhere, but here it could.
But I am fine with this approach (which is better to create a summary), just sharing my thoughts.
</discussion-mode:on>
| bats: | ||
| runs-on: ubuntu-18.04 | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I am planning to improve all the existing tests:
- With adding name to all the steps
- Use upper case for the first letter (default for github actions if the name is missing).
This is the same as the others, so I think we can merge it as is.
|
Thanks @elek for reviewing and committing it. |
* master: (55 commits) HDDS-4052. Remove master/slave terminology from Ozone (apache#1281) HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277) HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223) HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273) HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257) HDDS-4033. Make the acceptance test reports hierarchical (apache#1263) HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260) HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265) HDDS-4024. Avoid while loop too soon when exception happen (apache#1253) HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081) HDDS-4019. Show the storageDir while need init om or scm (apache#1248) HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247) HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267) HDDS-4031. Run shell tests in CI (apache#1261) HDDS-4038. Eliminate GitHub check warnings (apache#1268) HDDS-4011. Update S3 related documentation. (apache#1245) HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259) HDDS-4032. Run author check without docker (apache#1262) HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256) HDDS-4017. Acceptance check may run against wrong commit (apache#1249) ...
What changes were proposed in this pull request?
*.bats).batspart of CI.https://issues.apache.org/jira/browse/HDDS-4031
How was this patch tested?
Created failing test at
hadoop-hdds/common/src/test/shell/failing.bats:and tested:
Passing tests (currently only
gc_opts.bat):https://github.com/adoroszlai/hadoop-ozone/runs/913609741#step:4:4