HDDS-4033. Make the acceptance test reports hierarchical #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elek
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1263 +/- ##
============================================
- Coverage 73.95% 73.88% -0.08%
+ Complexity 10171 10148 -23
============================================
Files 974 974
Lines 50187 50187
Branches 4892 4892
============================================
- Hits 37115 37079 -36
- Misses 10756 10767 +11
- Partials 2316 2341 +25 Continue to review full report at Codecov.
|
adoroszlai
requested changes
Jul 27, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @elek for this nice improvement.
adoroszlai
requested changes
Jul 29, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @elek for refactoring find_tests. I found two issues in acceptance tests, and couple of necessary changes for the new bats check.
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
adoroszlai
approved these changes
Jul 29, 2020
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 31, 2020
* master: (55 commits) HDDS-4052. Remove master/slave terminology from Ozone (apache#1281) HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277) HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223) HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273) HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257) HDDS-4033. Make the acceptance test reports hierarchical (apache#1263) HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260) HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265) HDDS-4024. Avoid while loop too soon when exception happen (apache#1253) HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081) HDDS-4019. Show the storageDir while need init om or scm (apache#1248) HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247) HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267) HDDS-4031. Run shell tests in CI (apache#1261) HDDS-4038. Eliminate GitHub check warnings (apache#1268) HDDS-4011. Update S3 related documentation. (apache#1245) HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259) HDDS-4032. Run author check without docker (apache#1262) HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256) HDDS-4017. Acceptance check may run against wrong commit (apache#1249) ...
timmylicheng
pushed a commit
that referenced
this pull request
Aug 6, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Acceptance test reports of today uses a generated name for each of the executed robot tests.
Instead of using a flat structure with generated name it seems to be better to use a hierarchical structure which represents the directory structure.
before:
after:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4033
How was this patch tested?
Running CI on my fork:
https://github.com/elek/hadoop-ozone/runs/911471446?check_suite_focus=true
See the attached artifacts