-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-4031. Run shell tests in CI #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" | ||
| cd "${DIR}/../../.." || exit 1 | ||
|
|
||
| REPORT_DIR=${OUTPUT_DIR:-"${DIR}/../../../target/bats"} | ||
| mkdir -p "${REPORT_DIR}" | ||
| REPORT_FILE="${REPORT_DIR}/summary.txt" | ||
|
|
||
| rm -f "${REPORT_DIR}/output.log" | ||
|
|
||
| find * -path '*/src/test/shell/*' -name '*.bats' -print0 \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. discussion-mode:on This pattern ("fail at the end") is introduced to execute all the tests even if some of them are failing. It's very useful for long and flaky test runs. But it's somewhat more complex. Recently I started to think to use a "fail fast" approach. It can simplify the scripts and we can use It's not working everywhere, but here it could. But I am fine with this approach (which is better to create a summary), just sharing my thoughts. </discussion-mode:on> |
||
| | xargs -0 -n1 bats --formatter tap \ | ||
| | tee -a "${REPORT_DIR}/output.log" | ||
|
|
||
| grep '^\(not ok\|#\)' "${REPORT_DIR}/output.log" > "${REPORT_FILE}" | ||
|
|
||
| grep -c '^not ok' "${REPORT_FILE}" > "${REPORT_DIR}/failures" | ||
|
|
||
| if [[ -s "${REPORT_FILE}" ]]; then | ||
| exit 1 | ||
| fi | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future I am planning to improve all the existing tests:
This is the same as the others, so I think we can merge it as is.