HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no of volumes reported by it.
elek
approved these changes
Jun 24, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1, based on my understanding this is a good step forward.
Thanks to create this @bshashikant
Let's merge it after a green build.
...op-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
Outdated
Show resolved
Hide resolved
dineshchitlangia
previously requested changes
Jun 24, 2020
Contributor
dineshchitlangia
left a comment
dineshchitlangia
left a comment
There was a problem hiding this comment.
Overall LGTM. Few checkstyle issues need to be addressed and then we are good to merge.
adoroszlai
reviewed
Jul 9, 2020
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
Outdated
Show resolved
Hide resolved
adoroszlai
dismissed
dineshchitlangia’s stale review
checkstyle issues have been addressed
Contributor
|
Thanks @bshashikant for the contribution, @elek and @dineshchitlangia for the review. Merged to |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 31, 2020
* master: (55 commits) HDDS-4052. Remove master/slave terminology from Ozone (apache#1281) HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277) HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223) HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273) HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257) HDDS-4033. Make the acceptance test reports hierarchical (apache#1263) HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260) HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265) HDDS-4024. Avoid while loop too soon when exception happen (apache#1253) HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081) HDDS-4019. Show the storageDir while need init om or scm (apache#1248) HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247) HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267) HDDS-4031. Run shell tests in CI (apache#1261) HDDS-4038. Eliminate GitHub check warnings (apache#1268) HDDS-4011. Update S3 related documentation. (apache#1245) HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259) HDDS-4032. Run author check without docker (apache#1262) HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256) HDDS-4017. Acceptance check may run against wrong commit (apache#1249) ...
timmylicheng
pushed a commit
that referenced
this pull request
Aug 6, 2020
… no of volumes reported by it. (#1081)
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
… no of volumes reported by it. (apache#1081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added logic to take into account max no of healthy disks reported among the sets
of datanodes of a pipeline to get the total no of open containers per pipeline.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3809
How was this patch tested?
Added unit tests.