Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Replace "slave" with "worker", which is already established terminology, but there were a few leftover occurrences.

https://issues.apache.org/jira/browse/HDDS-4052

How was this patch tested?

The only remaining occurrences are deprecation warnings:

$ rg --ignore-case --no-ignore slave
hadoop-ozone/dist/src/shell/hdds/hadoop-config.sh
122:hadoop_deprecate_envvar HADOOP_SLAVES HADOOP_WORKERS
123:hadoop_deprecate_envvar HADOOP_SLAVE_NAMES HADOOP_WORKER_NAMES
124:hadoop_deprecate_envvar HADOOP_SLAVE_SLEEP HADOOP_WORKER_SLEEP

hadoop-ozone/dist/src/shell/hdds/hadoop-functions.sh
1016:    elif [[ -f "${HADOOP_CONF_DIR}/slaves" ]]; then
1017:      hadoop_error "WARNING: 'slaves' file has been deprecated. Please use 'workers' file instead."
1018:      worker_file=${HADOOP_CONF_DIR}/slaves

@adoroszlai adoroszlai self-assigned this Jul 31, 2020
@cxorm
Copy link
Member

cxorm commented Jul 31, 2020

Thank you for the contribution.
Agree the changes IMHO, +1

Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@vivekratnavel vivekratnavel merged commit 0651be8 into apache:master Jul 31, 2020
@vivekratnavel
Copy link
Contributor

@adoroszlai Thanks for working on this!

errose28 added a commit to errose28/ozone that referenced this pull request Jul 31, 2020
* master: (55 commits)
  HDDS-4052. Remove master/slave terminology from Ozone (apache#1281)
  HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277)
  HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223)
  HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273)
  HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257)
  HDDS-4033. Make the acceptance test reports hierarchical (apache#1263)
  HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260)
  HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265)
  HDDS-4024. Avoid while loop too soon when exception happen (apache#1253)
  HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081)
  HDDS-4019. Show the storageDir while need init om or scm (apache#1248)
  HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247)
  HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267)
  HDDS-4031. Run shell tests in CI (apache#1261)
  HDDS-4038. Eliminate GitHub check warnings (apache#1268)
  HDDS-4011. Update S3 related documentation. (apache#1245)
  HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259)
  HDDS-4032. Run author check without docker (apache#1262)
  HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256)
  HDDS-4017. Acceptance check may run against wrong commit (apache#1249)
  ...
@adoroszlai adoroszlai deleted the HDDS-4052 branch August 1, 2020 12:02
@adoroszlai
Copy link
Contributor Author

Thanks @cxorm and @vivekratnavel for the review.

vivekratnavel pushed a commit to vivekratnavel/hadoop-ozone that referenced this pull request Aug 8, 2020
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants