HIVE-26822: port changes before spotless #3857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InvisibleProgrammer
changed the title
InvisibleProgrammer
changed the title
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
…og level using catalog properties. apache#4011
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests failed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
InvisibleProgrammer
deleted the
HIVE-26822---Port-changes-before-spotless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: Port Iceberg catalog changes
That port contains a huge spotless refactor so we do the porting in three steps:
That PR contains the first pack of those
Changes contained in the port:
apache/iceberg#4456 - Hive: Expose Snapshot Stats in HMS.
apache/iceberg#4546 - Hive: Expose default partition spec and sort order in HMS. #4546
apache/iceberg#4681 - Core: Log the new metadata location in commit. #4681
apache/iceberg#5212 - Arrow/AWS/Core/Hive: Fix ErrorProne warnings #5212
apache/iceberg#5222 - Don't throw from finally block #5222
apache/iceberg#4585 - Core : Strip trailing slash from tableLocation in LocationProvider #4585
apache/iceberg#4011 - Allow table defaults to be configured and/ or enforced at catalog level using catalog properties. #4011
apache/iceberg#4803 - Catalog: Use ImmutableMap for catalog properties #4803
apache/iceberg#4946 - API: Support registering filesystem tables to metastore based catalogs #4946
apache/iceberg#5210 - Build: Upgrade test dependencies to latest version #5210
apache/iceberg#5221 - Prevent usage of @test(expected = ...) and change existing tests #5221
apache/iceberg#5037 - Core: Implement BaseMetastoreCatalog.registerTable() #5037
Wanted but couldn't as Hive-Iceberg and Iceberg have too many differences. They does that in a complete different way
apache/iceberg#5039 - Hive: Print db and table name while acquiring hive meta-store lock #5039
Was on the changelist but didn't contain file that should be ported:
apache/iceberg#4873 - API: Pass FileIO into Snapshot methods that read metadata #4873
What changes were proposed in this pull request?
Porting
Why are the changes needed?
The last round of porting happened in 2022 april, there were a couple of changes especially in HiveTableOperations worth porting into iceberg-catalog.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran the tests.