Arrow/AWS/Core/Hive: Fix ErrorProne warnings #5212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
error-prone-warnings
branch
from
603efe6 to
f6286ef
Compare
nastra
changed the title
kbendick
approved these changes
Jul 6, 2022
| * @return the columnbytes interleaved | ||
| */ | ||
| @SuppressWarnings("ByteBufferBackingArray") | ||
| // NarrowingCompoundAssignment is intended here. See https://github.com/apache/iceberg/pull/5200#issuecomment-1176226163 |
Member
There was a problem hiding this comment.
The only reason I don't have this documented more is that I was hoping we can get a better implementation in :)
I think we should write in some optimized versions for 2, 3, 4 columns since I think most cases will benefit in that range. Having more than that many Z order dimensions is probably a waste
Fokko
approved these changes
Jul 7, 2022
RussellSpitzer
approved these changes
Jul 7, 2022
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.