-
Notifications
You must be signed in to change notification settings - Fork 3k
Build: Upgrade test dependencies to latest version #5210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rebased due to merge conflict |
|
It makes sense to upgrade to me, but do you think we can leave out the ArgumentMatchers => Mockito refactor? It doesn't seem that valuable unless its enforced going forward, one way or the other. As any() is defined on ArgumentMatchers, I was actually thinking it makes sense to call it from where it is defined. |
this was the situation on master: so it looked like to me, that the any-methods from Mockito might be preferred across the codebase. i think generally it is not unusual to use wildcard imports with Mockito as an exception: that being said, i am fine to revert this part of the change if you still want me to? |
|
Yea , I do understand the desire to make it the same, but there's definitely many correct ways unless there is some definite rule, so I'd say let's revert those changes to focus this pr? Other changes look good to me. |
- upgrade junit5 to 5.8.2 - upgrade assertj to 3.23.1 - upgrade mockserver to 5.13.2 - upgrade mockito to 4.6.1 - org.mockito.Matchers class was removed
|
@szehon-ho ok i have removed the refactoring around |
|
Missed the message, thanks, looks good to me. Will wait a little bit to see any other comments, otherwise will merge soon. |
Uh oh!
There was an error while loading. Please reload this page.