Skip to content

Conversation

@dengzhhu653
Copy link
Member

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the column name in METASTORE_DB_PROPERTIES should have been PROPERTY_CONTENT like other columns, but I think we have to live with it now, due to compat issues...

There is no test which was checking the output?

@dengzhhu653
Copy link
Member Author

Ideally the column name in METASTORE_DB_PROPERTIES should have been PROPERTY_CONTENT like other columns, but I think we have to live with it now, due to compat issues...

There is no test which was checking the output?

There are some tests HMSDirectTest which are testing out the fetch or save of PROPERTY_CONTENT on derby, but they get through the test, not sure why.

@ayushtkn
Copy link
Member

hmm, do we need to catch someone from HMS side to figure out why those tests aren't working? I think it isn't an ideal situation for us, these bugs will keep on coming if those tests aren't working the way they should

@dengzhhu653
Copy link
Member Author

dengzhhu653 commented Nov 16, 2023

hmm, do we need to catch someone from HMS side to figure out why those tests aren't working? I think it isn't an ideal situation for us, these bugs will keep on coming if those tests aren't working the way they should

I filed a jira HIVE-27879 for this

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanx @dengzhhu653

@dengzhhu653 dengzhhu653 merged commit eb6f0b0 into apache:master Nov 17, 2023
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
…che#4873) (Zhihua Deng, reviewed by Attila Turoczy, Ayush Saxena)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants