HIVE-27562: Iceberg: Fetching virtual columns failing. #4546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbutao
reviewed
Aug 4, 2023
iceberg/iceberg-handler/src/test/queries/positive/query_iceberg_virtualcol.q
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Aug 4, 2023
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Aug 4, 2023
Member
deniskuzZ
left a comment
deniskuzZ
left a comment
There was a problem hiding this comment.
LGTM, minor code style comment
zhangbutao
reviewed
Aug 4, 2023
iceberg/iceberg-handler/src/test/results/positive/query_iceberg_virtualcol.q.out
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
zhangbutao
approved these changes
Aug 5, 2023
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
… (Ayush Saxena, reviewed by Denys Kuzmenko, zhangbutao)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add virtual column whenever the query is supposed to fetch them.
Why are the changes needed?
Fix fetching virtual columns for iceberg table, when no other column is being queried.
Does this PR introduce any user-facing change?
Queries only fetching virtual columns passes.
Is the change a dependency upgrade?
No
How was this patch tested?
UT