Skip to content

Conversation

@abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Apr 24, 2024

What changes were proposed in this pull request?

Use a different root folder in MiniHS2.

Why are the changes needed?

Describe on jira in detail, but TLDR SCRATCH_DIR makes much more sense to me.

Does this PR introduce any user-facing change?

No, MiniHS2 is a testing dev tool.

Is the change a dependency upgrade?

No.

How was this patch tested?

Locally tested with MiniHS2.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@simhadri-g simhadri-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@abstractdog abstractdog merged commit 4614ce7 into apache:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants