[GOBBLIN-1861] Fix bug with total count watermark whitelist

[jack-moseley]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-1861

Description

• Here are some details about my PR, including screenshots (if applicable):
  The total completion watermark whitelist was not respected when a change_property GMCE was sent. These should be treated the same as add_files GMCEs.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:
  Tested with a whitelisted and non-whitelisted topic in test pipeline.

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.03%. Comparing base (68e2590) to head (b08fcda).
⚠️ Report is 399 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3724      +/-   ##
============================================
+ Coverage     47.00%   47.03%   +0.02%     
- Complexity    10824    10825       +1     
============================================
  Files          2144     2144              
  Lines         84686    84686              
  Branches       9404     9404              
============================================
+ Hits          39810    39832      +22     
+ Misses        41249    41227      -22     
  Partials       3627     3627              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ZihanLi58]

+1