Skip to content

[GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0#3697

Merged
ZihanLi58 merged 5 commits intoapache:masterfrom
meethngala:upgrade-iceberg-version
Jun 14, 2023
Merged

[GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0#3697
ZihanLi58 merged 5 commits intoapache:masterfrom
meethngala:upgrade-iceberg-version

Conversation

@meethngala
Copy link
Copy Markdown
Contributor

@meethngala meethngala commented May 20, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

I want to upgrade our iceberg version to 1.2.0 to leverage performance improvements such as optimized metadata caching, reduced memory consumption, and faster metadata commits, enhanced APIs, schema evolution. Most importantly it natively provides support for Apache Spark 3.x, allowing seamless integration and improved performance when using Iceberg with Spark. As part of this upgrade, below are the major changes:

  • Update method signatures for CatalogUtil.loadCatalog() and Snapshots.allManifests
  • Initialize and load HiveCatalog via CatalogUtil inside IcebergMetadataWriter

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Updated unit tests
  • Successful Build

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Copy link
Copy Markdown
Contributor

@phet phet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.86%. Comparing base (a00b57c) to head (9096f57).
⚠️ Report is 422 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3697      +/-   ##
============================================
- Coverage     46.89%   46.86%   -0.04%     
  Complexity    10772    10772              
============================================
  Files          2138     2138              
  Lines         84139    84140       +1     
  Branches       9357     9357              
============================================
- Hits          39456    39428      -28     
- Misses        41078    41108      +30     
+ Partials       3605     3604       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meethngala meethngala force-pushed the upgrade-iceberg-version branch from cfc9b6c to baafed5 Compare June 12, 2023 22:15
Copy link
Copy Markdown
Contributor

@phet phet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, but one Q on the test you changed...

Copy link
Copy Markdown
Contributor

@ZihanLi58 ZihanLi58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ZihanLi58 ZihanLi58 merged commit 949b019 into apache:master Jun 14, 2023
phet added a commit to phet/gobblin that referenced this pull request Aug 15, 2023
* upstream/master:
  Fix bug with total count watermark whitelist (apache#3724)
  [GOBBLIN-1858] Fix logs relating to multi-active lease arbiter (apache#3720)
  [GOBBLIN-1838] Introduce total count based completion watermark (apache#3701)
  Correct num of failures (apache#3722)
  [GOBBLIN- 1856] Add flow trigger handler leasing metrics (apache#3717)
  [GOBBLIN-1857] Add override flag to force generate a job execution id based on gobbl… (apache#3719)
  [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0 (apache#3718)
  Remove unused ORC writer code (apache#3710)
  [GOBBLIN-1853] Reduce # of Hive calls during schema related updates (apache#3716)
  [GOBBLIN-1851] Unit tests for MysqlMultiActiveLeaseArbiter with Single Participant (apache#3715)
  [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility (apache#3712)
  [GOBBLIN-1849] Add Flow Group & Name to Job Config for Job Scheduler (apache#3713)
  [GOBBLIN-1841] Move disabling of current live instances to the GobblinClusterManager startup (apache#3708)
  [GOBBLIN-1840] Helix Job scheduler should not try to replace running workflow if within configured time (apache#3704)
  [GOBBLIN-1847] Exceptions in the JobLauncher should try to delete the existing workflow if it is launched (apache#3711)
  [GOBBLIN-1842] Add timers to GobblinMCEWriter (apache#3703)
  [GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count (apache#3709)
  [GOBBLIN-1846] Validate Multi-active Scheduler with Logs (apache#3707)
  [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilteringDecorator  to avoid classloader issues in spark (apache#3706)
  [GOBBLIN-1843] Utility for detecting non optional unions should convert dataset urn to hive compatible format (apache#3705)
  [GOBBLIN-1837] Implement multi-active, non blocking for leader host (apache#3700)
  [GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0 (apache#3697)
  Update CHANGELOG to reflect changes in 0.17.0
  Reserving 0.18.0 version for next release
  [GOBBLIN-1836] Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for Error-Free Completion (apache#3699)
  [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics (apache#3698)
  [GOBBLIN-1825]Hive retention job should fail if deleting underlying files fail (apache#3687)
  [GOBBLIN-1823] Improving Container Calculation and Allocation Methodology (apache#3692)
  [GOBBLIN-1830] Improving Container Transition Tracking in Streaming Data Ingestion (apache#3693)
  [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent (apache#3696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants