[GOBBLIN-1825]Hive retention job should fail if deleting underlying files fail

[meethngala]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-1825

Description

Hive retention would perform two tasks: drop the partition first and then delete the underlying files. Now, if for some reason the partition was dropped, but we couldn't delete the underlying files, the job would still succeed. Thus, if we try to re-run the job, it wouldn't fine any work and the hdfs files would never be discovered.

In order to avoid running into this situation, I have made the below changes:

• Delete the underlying files first and then try dropping the hive partition
• throw the exceptions and fail the job rather than marking the job status as successful

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-commenter]

Codecov Report

Merging #3687 (98f2b35) into master (22cfc5c) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #3687      +/-   ##
============================================
+ Coverage     46.87%   46.88%   +0.01%     
- Complexity    10756    10758       +2     
============================================
  Files          2138     2138              
  Lines         84018    84033      +15     
  Branches       9337     9338       +1     
============================================
+ Hits          39380    39399      +19     
+ Misses        41042    41036       -6     
- Partials       3596     3598       +2     

Impacted Files	Coverage Δ
...t/retention/version/HiveDatasetVersionCleaner.java	76.19% <33.33%> (-3.48%)	⬇️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ZihanLi58]

+1