[GOBBLIN-1843] Utility for detecting non optional unions should convert dataset urn to hive compatible format#3705
Merged
ZihanLi58 merged 3 commits intoapache:masterfrom Jun 15, 2023
Conversation
…rt dataset urn to hive compatible format
| return new DbAndTable(m.group(1), m.group(2)); | ||
|
|
||
| // hive does not use '-' in the table name, so they are replaced with '_' | ||
| String hiveTableName = m.group(2).replaceAll("-", "_"); |
Contributor
There was a problem hiding this comment.
Let's create a new method and use it here and in HiveTable.java line 45
homatthew
force-pushed
the
mh-nonoptionalunion-fix-GOBBLIN-1843
branch
from
2a3d8b2 to
9bd3daf
Compare
arjun4084346
approved these changes
Jun 14, 2023
homatthew
force-pushed
the
mh-nonoptionalunion-fix-GOBBLIN-1843
branch
from
9bd3daf to
8e372ce
Compare
homatthew
force-pushed
the
mh-nonoptionalunion-fix-GOBBLIN-1843
branch
from
8e372ce to
4115837
Compare
vikrambohra
approved these changes
Jun 15, 2023
Codecov Report
@@ Coverage Diff @@
## master #3705 +/- ##
============================================
+ Coverage 46.87% 49.48% +2.61%
+ Complexity 10771 9317 -1454
============================================
Files 2138 1756 -382
Lines 84139 68480 -15659
Branches 9357 7810 -1547
============================================
- Hits 39436 33885 -5551
+ Misses 41102 31455 -9647
+ Partials 3601 3140 -461
... and 404 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phet
added a commit
to phet/gobblin
that referenced
this pull request
Aug 15, 2023
* upstream/master: Fix bug with total count watermark whitelist (apache#3724) [GOBBLIN-1858] Fix logs relating to multi-active lease arbiter (apache#3720) [GOBBLIN-1838] Introduce total count based completion watermark (apache#3701) Correct num of failures (apache#3722) [GOBBLIN- 1856] Add flow trigger handler leasing metrics (apache#3717) [GOBBLIN-1857] Add override flag to force generate a job execution id based on gobbl… (apache#3719) [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0 (apache#3718) Remove unused ORC writer code (apache#3710) [GOBBLIN-1853] Reduce # of Hive calls during schema related updates (apache#3716) [GOBBLIN-1851] Unit tests for MysqlMultiActiveLeaseArbiter with Single Participant (apache#3715) [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility (apache#3712) [GOBBLIN-1849] Add Flow Group & Name to Job Config for Job Scheduler (apache#3713) [GOBBLIN-1841] Move disabling of current live instances to the GobblinClusterManager startup (apache#3708) [GOBBLIN-1840] Helix Job scheduler should not try to replace running workflow if within configured time (apache#3704) [GOBBLIN-1847] Exceptions in the JobLauncher should try to delete the existing workflow if it is launched (apache#3711) [GOBBLIN-1842] Add timers to GobblinMCEWriter (apache#3703) [GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count (apache#3709) [GOBBLIN-1846] Validate Multi-active Scheduler with Logs (apache#3707) [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilteringDecorator to avoid classloader issues in spark (apache#3706) [GOBBLIN-1843] Utility for detecting non optional unions should convert dataset urn to hive compatible format (apache#3705) [GOBBLIN-1837] Implement multi-active, non blocking for leader host (apache#3700) [GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0 (apache#3697) Update CHANGELOG to reflect changes in 0.17.0 Reserving 0.18.0 version for next release [GOBBLIN-1836] Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for Error-Free Completion (apache#3699) [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics (apache#3698) [GOBBLIN-1825]Hive retention job should fail if deleting underlying files fail (apache#3687) [GOBBLIN-1823] Improving Container Calculation and Allocation Methodology (apache#3692) [GOBBLIN-1830] Improving Container Transition Tracking in Streaming Data Ingestion (apache#3693) [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent (apache#3696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Datasets with URN that have a
-will be represented in Hive with an_. Failing to do so will mean the code will fail to pull up the correct hive tableThis code will replace all '-' with '_' before querying hive. We do not need to consider lower / uppercase because hive is case insensitive
Tests
Commits