[GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count

[homatthew]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1844] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-1844

Description

• Here are some details about my PR, including screenshots (if applicable):
  When the GobblinClusterManager starts, it will do an asynchronous deletion of workflows (all workflow deletions are technically async). And we do not want the yarn service to acknowledge these workflows while the controller processes the request asynchronously.

When there is heavy load on the zookeeper cluster, the deletes will be slow and there will be significant overlap of having 2 of the same workflows

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Modified existing unit to cover edge case of workflows that marked for deletion. Also refactored the testing code to improve the readability since there is a ton of copy paste involved for creating a workflow which is difficult to read

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[homatthew]

This is the test that covers the related impl changes. The changes in the other test methods are all refactors

[ZihanLi58]

LGTM overall, just a minor comment

[ZihanLi58]

+1, thanks for addressing the comments

[codecov-commenter]

Codecov Report

Merging #3709 (33674da) into master (fc508ca) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #3709      +/-   ##
============================================
- Coverage     46.87%   46.82%   -0.05%     
- Complexity    10771    10801      +30     
============================================
  Files          2138     2141       +3     
  Lines         84139    84431     +292     
  Branches       9357     9385      +28     
============================================
+ Hits          39436    39539     +103     
- Misses        41102    41290     +188     
- Partials       3601     3602       +1     

Impacted Files	Coverage Δ
...rg/apache/gobblin/yarn/YarnAutoScalingManager.java	57.24% <75.00%> (+0.62%)	⬆️

... and 43 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more