Skip to content

[GOBBLIN-1838] Introduce total count based completion watermark#3701

Merged
ZihanLi58 merged 8 commits intoapache:masterfrom
wsarecv:tqin/total
Jul 24, 2023
Merged

[GOBBLIN-1838] Introduce total count based completion watermark#3701
ZihanLi58 merged 8 commits intoapache:masterfrom
wsarecv:tqin/total

Conversation

@wsarecv
Copy link
Copy Markdown
Contributor

@wsarecv wsarecv commented May 30, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    • Currently the completion watermark is determined according to the completeness percentage: max of srcCount/refCount, for each refTier. This change introduces a new "total count based completion watermark", which is determined by a new completeness percentage: srcCount / sum of all refCount, for each refTier. The new total count based watermark will be used to check the completeness of data which is aggregated from multiple tiers.
    • This PR also refactors existing codes and introduces CompletenessWatermarkUpdater.

Tests

  • My PR adds new test cases in the following unit tests:
    • adds new test cases in the existing KafkaAuditCountVerifierTest and IcebergMetadataWriterTest
    • adds new unit test CompletenessWatermarkUpdaterTest

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #3701 (6afb4cd) into master (51a852d) will decrease coverage by 1.96%.
The diff coverage is 79.72%.

@@             Coverage Diff              @@
##             master    #3701      +/-   ##
============================================
- Coverage     46.97%   45.02%   -1.96%     
+ Complexity    10794     2123    -8671     
============================================
  Files          2138      414    -1724     
  Lines         84132    17823   -66309     
  Branches       9356     2172    -7184     
============================================
- Hits          39518     8024   -31494     
+ Misses        41015     8930   -32085     
+ Partials       3599      869    -2730     
Impacted Files Coverage Δ
...ceberg/writer/IcebergMetadataWriterConfigKeys.java 0.00% <ø> (ø)
...completeness/verifier/KafkaAuditCountVerifier.java 67.64% <72.72%> (+16.48%) ⬆️
.../gobblin/iceberg/writer/IcebergMetadataWriter.java 72.53% <74.35%> (+0.21%) ⬆️
...g/writer/AbstractCompletenessWatermarkUpdater.java 78.43% <78.43%> (ø)
...n/iceberg/writer/CompletenessWatermarkUpdater.java 100.00% <100.00%> (ø)
...writer/TotalCountCompletenessWatermarkUpdater.java 100.00% <100.00%> (ø)

... and 1730 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wsarecv wsarecv requested a review from ZihanLi58 June 8, 2023 10:02
Copy link
Copy Markdown
Contributor

@ZihanLi58 ZihanLi58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ZihanLi58 ZihanLi58 merged commit ba408f2 into apache:master Jul 24, 2023
phet added a commit to phet/gobblin that referenced this pull request Aug 15, 2023
* upstream/master:
  Fix bug with total count watermark whitelist (apache#3724)
  [GOBBLIN-1858] Fix logs relating to multi-active lease arbiter (apache#3720)
  [GOBBLIN-1838] Introduce total count based completion watermark (apache#3701)
  Correct num of failures (apache#3722)
  [GOBBLIN- 1856] Add flow trigger handler leasing metrics (apache#3717)
  [GOBBLIN-1857] Add override flag to force generate a job execution id based on gobbl… (apache#3719)
  [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0 (apache#3718)
  Remove unused ORC writer code (apache#3710)
  [GOBBLIN-1853] Reduce # of Hive calls during schema related updates (apache#3716)
  [GOBBLIN-1851] Unit tests for MysqlMultiActiveLeaseArbiter with Single Participant (apache#3715)
  [GOBBLIN-1848] Add tags to dagmanager metrics for extensibility (apache#3712)
  [GOBBLIN-1849] Add Flow Group & Name to Job Config for Job Scheduler (apache#3713)
  [GOBBLIN-1841] Move disabling of current live instances to the GobblinClusterManager startup (apache#3708)
  [GOBBLIN-1840] Helix Job scheduler should not try to replace running workflow if within configured time (apache#3704)
  [GOBBLIN-1847] Exceptions in the JobLauncher should try to delete the existing workflow if it is launched (apache#3711)
  [GOBBLIN-1842] Add timers to GobblinMCEWriter (apache#3703)
  [GOBBLIN-1844] Ignore workflows marked for deletion when calculating container count (apache#3709)
  [GOBBLIN-1846] Validate Multi-active Scheduler with Logs (apache#3707)
  [GOBBLIN-1845] Changes parallelstream to stream in DatasetsFinderFilteringDecorator  to avoid classloader issues in spark (apache#3706)
  [GOBBLIN-1843] Utility for detecting non optional unions should convert dataset urn to hive compatible format (apache#3705)
  [GOBBLIN-1837] Implement multi-active, non blocking for leader host (apache#3700)
  [GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0 (apache#3697)
  Update CHANGELOG to reflect changes in 0.17.0
  Reserving 0.18.0 version for next release
  [GOBBLIN-1836] Ensuring Task Reliability: Handling Job Cancellation and Graceful Exits for Error-Free Completion (apache#3699)
  [GOBBLIN-1805] Check watermark for the most recent hour for quiet topics (apache#3698)
  [GOBBLIN-1825]Hive retention job should fail if deleting underlying files fail (apache#3687)
  [GOBBLIN-1823] Improving Container Calculation and Allocation Methodology (apache#3692)
  [GOBBLIN-1830] Improving Container Transition Tracking in Streaming Data Ingestion (apache#3693)
  [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent (apache#3696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants