Merged
Conversation
Basically used by the Sidebar, which will stop holding "Page" or "Contextual" actions. Another slot will be created for them in order to make these actions more discoverable.
Based in the PatternFly Dropdown component[1] and intended for displaying the actions related to the current page in an attempt to make them more discoverable. [1] https://www.patternfly.org/v4/components/dropdown
And stop using the somehow "deprecated" PageOptions.
Moving the actions to its own NetworkPageOptions page and stop using the "deprecated" PageOptions to show them in the Sidebar.
Now that we are going to stop teleporting links to the Sidebar and start using another location for placing the page related links, the "Change product" action will always be displayed in the Sidebar since, at least initially, we don't want to relate actions only to the Overview.
It'll become no longer needed
No longer needed since we've decided to stop teleporting page related actions to make them more discoverable.
Forgotten at dd0065b
For not displaying it when the WiFi scan is not supported. See #545 (comment)
The option for configuring additional devices should be discoverable enough now and, hopefully, the user does not need to be taught anymore about where to find options related to a specific page. What is more, it's no longer true that such actions can be done from the Sidebar.
Because the use case [1] for which it was introduced was already gone: to provide a link for directly opening the sidebar from a text teaching the user where to find page related actions. We can bring back the component if needed, but let's get rid of it now. This commit "reverts" f1a56eb, df85b3c, and a bit of f39f65d [1] #500
Because the component is more related to a PageMenu or PageOptions and not to a "contextual actions".
A simple component for rendering a notification/status mark, consisting of an absolute right positioned circle on top of a relative positioned element. The idea is to catch the users' attention for clicking on the element presenting the mark, but having in mind that they can continue with the installation without doing so.
[web] Change the location of page options
[web] Add a the initial version of a notification mark
Increase the timeout in the test
Since it can be confusing
[web] Do not show group options name until needed
- Add notification context
- Description from YaST storage issues usally refers to YaST features like the Expert Partitioner. It would be weird to show that kind of messages in Agama.
Add storage issues
Pull Request Test Coverage Report for Build 4894234270
💛 - Coveralls |
[web] Fix CI and update README screenshots
Load proposal if needed
dgdavid
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging issues branch into master. This PR includes:
Note that all those PRs have been individually reviewed.