Load proposal if needed#559
Merged
joseivanlopez merged 2 commits intoagama-project:issuesfrom May 5, 2023
Merged
Conversation
joseivanlopez
force-pushed
the
fix-proposal-page
branch
from
6723006 to
32aaa54
Compare
Pull Request Test Coverage Report for Build 4893834790
💛 - Coveralls |
Merged
|
Changes unknown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the proposal page is visited before having a proposal, then the page is always in loading state.
Solution
Loads the proposal if there is no proposal yet and the service finishes to calculate a proposal.
Testing