[web] Fix CI and update README screenshots#553
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
dgdavid
force-pushed
the
fix-take-screenshots-test
branch
2 times, most recently
from
88be671 to
e9cc25e
Compare
By replacing the no longer available storage settings popup by the users page.
dgdavid
force-pushed
the
fix-take-screenshots-test
branch
from
e9cc25e to
62de9cf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Increase the timeout in the test
Merged
dgdavid
changed the title
lslezak
approved these changes
May 5, 2023
dgdavid
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the storage settings popup is no longer available, let's replace its screenshot by the one for the users page in the README.
Note that this PR also introduce two small fixes or improvements for the CI task:
/devin the container to allow libstorage find devices