Add storage issues#540
Merged
joseivanlopez merged 12 commits intoagama-project:issuesfrom May 4, 2023
Merged
Conversation
joseivanlopez
force-pushed
the
storage-issues
branch
from
ce17fa9 to
15552c5
Compare
joseivanlopez
force-pushed
the
storage-issues
branch
4 times, most recently
from
eb41979 to
71f25c5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
joseivanlopez
force-pushed
the
storage-issues
branch
from
bf76d58 to
22e0283
Compare
dgdavid
reviewed
Apr 26, 2023
joseivanlopez
force-pushed
the
storage-issues
branch
from
22e0283 to
6157602
Compare
joseivanlopez
force-pushed
the
storage-issues
branch
from
fe767c0 to
8ca7aba
Compare
dgdavid
reviewed
May 2, 2023
dgdavid
reviewed
May 2, 2023
joseivanlopez
force-pushed
the
storage-issues
branch
from
4c6d1d2 to
2789de7
Compare
- Add notification context
joseivanlopez
force-pushed
the
storage-issues
branch
from
2789de7 to
9878116
Compare
- Description from YaST storage issues usally refers to YaST features like the Expert Partitioner. It would be weird to show that kind of messages in Agama.
dgdavid
reviewed
May 3, 2023
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments. Once again, I'd ask for another review from someone less involved than me in the PR.
dgdavid
approved these changes
May 3, 2023
Merged
dgdavid
added a commit
that referenced
this pull request
Jun 2, 2025
The `toValidationError` function is no longer in use. It was originally introduced in the storage area implementation (#540, commit 1fc1f6f) but its usage was gradually phased out across later changes (e.g., #1112), until it became fully unused in commit 9cfc9c7 (part of #1972). Removing it to reduce dead code and simplify the utils namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The validation mechanism of Agama is being replaced by a more generic approach based on the issues concept, see #548. Till now, only the storage service is using issues. But the UI is not adapted yet.
Solution
Adapt UI to work with storage issues. Moreover, a new page is added to show all the current issues. The sidebar also shows a notification mark if there are issues.
Note that the probing issues are now listed in the new issues page.
Testing
NOTE: there is a failing integration test. It is not clear why the test is faililng, but the problem should not be related to the changes in this PR. The fix for that integration tests will be done in a separate PR, see #553.
Screenshots
Show/hide